#1 PDF Application on GitHub that lets you edit PDFs on any device anywhere
V2 Fix subcategory names in All Tools (and search) pane (#4252)
# Description of Changes Because we used string typing for IDs and names, it was really easy to make mistakes where variables named like `subcategory` would be stored as an ID in one file, but then read assuming it's a name in another file. This PR changes the code to consistently use enum cases when referring to IDs of categories, subcategories, and tools (at least in as many places as I can find them, ~I had to add a `ToolId` enum for this work~ I originally added a `ToolId` type for this work, but it caused too many issues when merging with #4222 so I've pulled it back out for now). Making that change made it obvious where we were inconsistently passing IDs and reading them as names etc. allowing me to fix rendering issues in the All Tools pane, where the subcategory IDs were being rendered directly (instead of being translated) or where IDs were being translated into names, but were then being re-translated, causing warnings in the log.
J
James Brunton committed
7d9c0b0298c831cb9be93dda31a315f58e0b9071
Parent: 949ffa0
Committed by GitHub <noreply@github.com>
on 8/22/2025, 12:53:06 PM