#1 PDF Application on GitHub that lets you edit PDFs on any device anywhere
Potential fix for code scanning alert no. 224: DOM text reinterpreted as HTML (#3499)
Potential fix for [https://github.com/Stirling-Tools/Stirling-PDF/security/code-scanning/224](https://github.com/Stirling-Tools/Stirling-PDF/security/code-scanning/224) To fix the issue, we should avoid assigning untrusted data directly to `innerHTML`. Instead, we can use `textContent`, which safely sets the text content of an element without interpreting it as HTML. This ensures that any special characters in the `data-title` attribute are treated as plain text, preventing XSS attacks. The fix involves replacing `tabButton.innerHTML = title;` on line 12 with `tabButton.textContent = title;`. This change ensures that the `title` is safely rendered as text. --- _Suggested fixes powered by Copilot Autofix. Review carefully before merging._ Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
A
Anthony Stirling committed
fd1e854778bf61276971f3747b89b3d2ad646f1e
Parent: c4b8df2
Committed by GitHub <noreply@github.com>
on 5/8/2025, 5:19:55 PM