Remove octant_offset_c uniform from ubersdf, reorder/document ubersdf uniforms (#191597)
Followup to https://github.com/flutter/flutter/pull/191235 (Move more RSE rendering cases to complex_rse.frag). In that PR, there was some discussion about whether removing the `octant_offset_c` uniform would have an affect on the registers used reported by malioc. We decided that we didn't need to remove `octant_offset_c`. But from testing out the ubesdf gradient changes (https://github.com/flutter/flutter/pull/190874) after merging with https://github.com/flutter/flutter/pull/191235, the Mali-G78 registers used on Vulkan (flutter/impeller/entity/uber_sdf.frag.vkspv) is still 66. Removing `octant_offset_c` brings the registers used down by 2, as seen in the malioc changes in this PR. So this is needed to bring down the registers used to 64 when the gradient changes are included. This PR also incorporates the reordering and adding of comments to uber_sdf's uniforms. This way the upcoming gradient change is scoped to only adding the new gradient functionality for easier review. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
B
b-luk committed
62d06a3f757b9a5d5ffa67fef3ffc0a6fdb94434
Parent: a1fee3b
Committed by GitHub <noreply@github.com>
on 8/25/2026, 2:54:39 AM