SIGN IN SIGN UP
expressjs / express UNCLAIMED

Fast, unopinionated, minimalist web framework for node.

0 0 59 JavaScript

Ignore `expires` and `maxAge` in `res.clearCookie()` (#5792)

* add test for removing user provided expires

* rework impl and tests to ignore maxAge, do not set it

this is to take into account the built-in relative expires when passing
a maxAge to res.cookie

I realized that using maxAge to invalidate cookies inherrently hit this
relativee expires behavior, and the goal of this PR is not to rework
that relative expires behavior w/ maxAge, but to prevent users from
overwriting these values by accident when clearing cookies

* update history.md

* explicitly delete maxAge instead of setting as undefined

* drop the spread, use object.assign

* wording, review comment on history.md

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>

* ♻️ use spread, update supported ecmascript version

---------

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
J
Jon Church committed
82fc12a40b3e6694e9a2c9b1376e7548d95779f6
Parent: 160b91c
Committed by GitHub <noreply@github.com> on 8/2/2024, 8:26:45 PM