SIGN IN SIGN UP
laurent22 / joplin UNCLAIMED

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.

0 0 235 TypeScript

Desktop: Fix handling of certain keys in shortcut editor (#4022)

String.fromCharCode expects unicode charcodes as an argument; e.keyCode returns javascript keycodes.
Javascript keycodes and unicode charcodes are not the same thing!

Therefore I used an array to map keycodes. This seems to be the only way to make this work properly.

I also changed the width of the shortcut recorder input field to 200px, since certain key combinations are cut off, because they don't fit in the field.
H
Helmut K. C. Tessarek committed
340312fa809abc2e12fea1dd0b9e8ff33173bba9
Parent: 0062399
Committed by GitHub <noreply@github.com> on 11/12/2020, 6:40:00 PM