SIGN IN SIGN UP
videojs / video.js UNCLAIMED

Video.js - open source HTML5 video player

0 0 6 JavaScript

fix(types): ensure toggleClass's second arg is optional (#8829)

## Description
Generated types are mangled for `Component.toggleClass()`, because tsc
doesn't understand `~` namespaces. The second arg is then not marked as
optional.

## Specific Changes proposed
Refactor JSDoc

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [ ] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
M
mister-ben committed
65f854678293c2942bebe076ac1a3b51f49645ab
Parent: e715145
Committed by GitHub <noreply@github.com> on 8/14/2024, 7:00:01 PM